fix: Handle zero case for API usage limit #4428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker builds report
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4428 +/- ##
=======================================
Coverage 96.84% 96.84%
=======================================
Files 1167 1167
Lines 38684 38686 +2
=======================================
+ Hits 37462 37464 +2
Misses 1222 1222 ☔ View full report in Codecov by Sentry. |
novakzaballa
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #4411
During tests on staging a divide by zero condition was reached when the amount of API usage for a given customer was zero. I'm not sure if the same bad data exists on production, but either way a reasonable default to the free plan size is justified. While I was at it, I also set the default value of the field to point to the pre-existing constant so if we ever change the free default we won't have to search for the value.
How did you test this code?
I did not test the code since it's pretty obvious.