Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app_analytics): Add cache for feature evaluation #4418

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Jul 30, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Create and use cache to batch feature evaluation calls to reduce load on task processor

How did you test this code?

Added unit test

@gagantrivedi gagantrivedi requested a review from a team as a code owner July 30, 2024 06:27
@gagantrivedi gagantrivedi requested review from khvn26 and removed request for a team July 30, 2024 06:27
Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Aug 7, 2024 2:23pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Aug 7, 2024 2:23pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Aug 7, 2024 2:23pm

@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Jul 30, 2024
Copy link
Contributor

github-actions bot commented Jul 30, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4418 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4418 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4418 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4418 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4418 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4418 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jul 30, 2024

Uffizzi Preview deployment-54779 was deleted.

@gagantrivedi gagantrivedi force-pushed the feat/feature-eval-cache branch from a330417 to 136b7f6 Compare July 30, 2024 06:43
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 30, 2024
@gagantrivedi gagantrivedi force-pushed the feat/feature-eval-cache branch from 136b7f6 to a0b390f Compare July 30, 2024 07:22
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.89%. Comparing base (3f745c5) to head (cd7150f).
Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4418      +/-   ##
==========================================
+ Coverage   96.83%   96.89%   +0.06%     
==========================================
  Files        1165     1172       +7     
  Lines       38621    39082     +461     
==========================================
+ Hits        37398    37868     +470     
+ Misses       1223     1214       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi force-pushed the feat/feature-eval-cache branch from a0b390f to b4cc71e Compare July 30, 2024 07:52
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 30, 2024
@gagantrivedi gagantrivedi force-pushed the feat/feature-eval-cache branch from b4cc71e to 689296f Compare July 30, 2024 07:53
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 30, 2024
Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions and two nitpicks. Otherwise, looks good.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 5, 2024
@gagantrivedi gagantrivedi force-pushed the feat/feature-eval-cache branch from e14c3d7 to 689296f Compare August 5, 2024 08:19
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 5, 2024
@gagantrivedi gagantrivedi requested a review from khvn26 August 7, 2024 14:52
@gagantrivedi gagantrivedi added this pull request to the merge queue Aug 8, 2024
Merged via the queue into main with commit 2dfbf99 Aug 8, 2024
35 checks passed
@gagantrivedi gagantrivedi deleted the feat/feature-eval-cache branch August 8, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants