Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add command for Edge V2 migration #4415

Merged
merged 2 commits into from
Jul 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions api/app/settings/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@
"organisations.permissions",
"projects",
"sales_dashboard",
"edge_api",
"environments",
"environments.permissions",
"environments.identities",
Expand Down
5 changes: 5 additions & 0 deletions api/edge_api/apps.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
from django.apps import AppConfig


class EdgeAPIAppConfig(AppConfig):
name = "edge_api"
Empty file.
17 changes: 17 additions & 0 deletions api/edge_api/management/commands/migrate_to_edge_v2.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
from typing import Any

from django.core.management import BaseCommand

from projects.models import EdgeV2MigrationStatus, Project
from projects.tasks import migrate_project_environments_to_v2


class Command(BaseCommand):
def handle(self, *args: Any, **options: Any) -> str | None:
for project_id in Project.objects.filter(
edge_v2_migration_status__in=(
EdgeV2MigrationStatus.NOT_STARTED,
EdgeV2MigrationStatus.INCOMPLETE,
)
).values_list("id", flat=True):
migrate_project_environments_to_v2(project_id)
41 changes: 41 additions & 0 deletions api/tests/unit/edge_api/test_unit_edge_api_commands.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
from django.core.management import call_command
from pytest_mock import MockerFixture

from projects.models import EdgeV2MigrationStatus, Project


def test_migrate_to_edge_v2__new_projects__dont_migrate(
mocker: MockerFixture, project: Project
) -> None:
# Given
# unmigrated projects are present
unmigrated_projects = Project.objects.bulk_create(
[
Project(
name="edge_v2_not_started",
organisation=project.organisation,
edge_v2_migration_status=EdgeV2MigrationStatus.NOT_STARTED,
),
Project(
name="edge_v2_incomplete",
organisation=project.organisation,
edge_v2_migration_status=EdgeV2MigrationStatus.INCOMPLETE,
),
],
)

migrate_project_environments_to_v2_mock = mocker.patch(
"edge_api.management.commands.migrate_to_edge_v2.migrate_project_environments_to_v2",
autospec=True,
)

# When
call_command("migrate_to_edge_v2")

# Then
# unmigrated projects were migrated
migrate_project_environments_to_v2_mock.assert_has_calls(
[mocker.call(project.id) for project in unmigrated_projects]
)
# the migrated `project` was not redundantly migrated
migrate_project_environments_to_v2_mock.call_count == len(unmigrated_projects)
Loading