-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Backend support for Organisation-level integrations #4400
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4400 +/- ##
==========================================
+ Coverage 96.94% 97.14% +0.19%
==========================================
Files 1180 1154 -26
Lines 39679 39808 +129
==========================================
+ Hits 38467 38670 +203
+ Misses 1212 1138 -74 ☔ View full report in Codecov by Sentry. |
d1780a2
to
db5d694
Compare
37bcf46
to
a398235
Compare
182f2ab
to
2f4749d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good apart from two minor things:
- Missing coverage
- Test for delete
response = test_user_client.get(url) | ||
|
||
# Then | ||
assert response.status_code == status.HTTP_403_FORBIDDEN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a test for delete as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Contributes to #4391, #4434
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
This adds base classes to enable organisation-level audit log integrations, and adds Grafana as one.
How did you test this code?
Added numerous new unit tests to test new code paths and some of the old uncovered ones.