chore(sales-dashboard): optimise sales dashboard search query #4377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4377 +/- ##
==========================================
+ Coverage 96.81% 96.82% +0.01%
==========================================
Files 1165 1165
Lines 38526 38561 +35
==========================================
+ Hits 37299 37338 +39
+ Misses 1227 1223 -4 ☔ View full report in Codecov by Sentry. |
matthewelwell
force-pushed
the
chore(sales-dashboard)/fix-bad-query-for-skai
branch
from
6e04853 to
b9714fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix badly performing query in the sales dashboard for certain search terms.
How did you test this code?
Ran the sales dashboard locally and grabbed the resulting SQL query from the queryset, ran this against the production database to confirm that the query returned within a reasonable time period.