Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Organisation/Project dropdown not reset after closing #4365

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix: Organisation/Project dropdown not reset after closing #4365

merged 1 commit into from
Jul 23, 2024

Conversation

novakzaballa
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fix #4257

Before:

project.dropdown.mov

After:

Screen.Recording.2024-07-22.at.11.10.56.AM.mov

How did you test this code?

  1. Open the Organisation/Project dropdown.
  2. Hover over an Organisation and a project with the mouse.
  3. Close the dropdown.
  4. Reopen it (now it returns to the selected organization/project).

@novakzaballa novakzaballa requested a review from a team as a code owner July 22, 2024 15:23
@novakzaballa novakzaballa requested review from kyle-ssg and removed request for a team July 22, 2024 15:23
@vercel Vercel
Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 3:23pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 3:23pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jul 22, 2024 3:23pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Jul 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 22, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4365 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4365 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4365 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4365 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4365 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4365 Finished ✅ Results ✅

@novakzaballa novakzaballa requested a review from rolodato July 22, 2024 15:23
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 22, 2024 •
edited
Loading

Uffizzi Preview deployment-54473 was deleted.

@matthewelwell matthewelwell added this pull request to the merge queue Jul 23, 2024
Merged via the queue into main with commit 1af5d48 Jul 23, 2024
30 checks passed
@matthewelwell matthewelwell deleted the fix/organisation-project-dropdown-not-reset-after-closing branch July 23, 2024 16:59
@flagsmithdev flagsmithdev mentioned this pull request Jul 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

@kyle-ssg kyle-ssg Awaiting requested review from kyle-ssg kyle-ssg is a code owner automatically assigned from Flagsmith/flagsmith-front-end

@rolodato rolodato Awaiting requested review from rolodato

Assignees
No one assigned
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Organisation/project dropdown not reset after closing
2 participants
@novakzaballa @matthewelwell