Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent "Create Segment" button from disappearing when deleting the last segment #4314

Merged
merged 1 commit into from
Jul 12, 2024
Merged

fix: Prevent "Create Segment" button from disappearing when deleting the last segment #4314

merged 1 commit into from
Jul 12, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Jul 9, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

If a project has feature-specific segments but no standard segments, the UI Shows an empty table.

This PR simplifies the page and brings it inline with other entity pages when there are no results.

image

How did you test this code?

Deleted segments

@kyle-ssg kyle-ssg requested a review from a team as a code owner July 9, 2024 10:10
@kyle-ssg kyle-ssg requested review from novakzaballa and removed request for a team July 9, 2024 10:10
@vercel Vercel
Copy link

vercel bot commented Jul 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 10:11am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 10:11am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jul 9, 2024 10:11am

@kyle-ssg kyle-ssg linked an issue Jul 9, 2024 that may be closed by this pull request
"Create Segment" disappears when deleting last segment #4256
Closed
4 tasks
@github-actions github-actions bot added fix front-end Issue related to the React Front End Dashboard and removed fix labels Jul 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

flagsmith-api image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api:pr-4314 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

flagsmith-private-cloud image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4314 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

flagsmith-e2e image build finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4314 Finished ✅ Skipped

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

flagsmith-frontend image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-frontend:pr-4314 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

flagsmith image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith:pr-4314 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

Uffizzi Preview deployment-53985 was deleted.

@kyle-ssg kyle-ssg requested a review from rolodato July 9, 2024 10:56
novakzaballa
novakzaballa approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not sure if the info message is necessary.

rolodato
rolodato approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@rolodato rolodato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a suggestion for a more customer-facing title, something like fix: Prevent "Create Segment" button from disappearing when deleting the last segment

@matthewelwell matthewelwell changed the title fix: Remove create first segment ui fix: Prevent "Create Segment" button from disappearing when deleting the last segment Jul 12, 2024
@matthewelwell matthewelwell added this pull request to the merge queue Jul 12, 2024
Merged via the queue into main with commit cd121e8 Jul 12, 2024
28 checks passed
@matthewelwell matthewelwell deleted the fix/remove-create-first-segment-ui branch July 12, 2024 08:23
@flagsmithdev flagsmithdev mentioned this pull request Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolodato rolodato rolodato approved these changes

@novakzaballa novakzaballa novakzaballa approved these changes

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Create Segment" disappears when deleting last segment
4 participants
@kyle-ssg @rolodato @novakzaballa @matthewelwell