-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Plan based access UI #4281
Conversation
# Conflicts: # frontend/web/components/pages/EnvironmentSettingsPage.js
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uffizzi Preview |
Actually, I believe it does but this feature acts differently to others in that it's not organisation specific. If any of your orgs are paid it unlocks it. Also, I've just added this for custom fields. |
Thanks for the updates! What I meant about SAML is that we're currently hiding the SAML tab entirely from non-Enterprise orgs here: flagsmith/frontend/web/components/pages/OrganisationSettingsPage.js Lines 236 to 239 in 40bdd54
For example, a free self-hosted org sees this: Instead of hiding the SAML tab, we could always show it to all users, but disable the contents of the SAML page depending on the org's plan, in the same way we're disabling features per plan instead of hiding them in this PR. |
Ah good catch thanks, added here @rolodato |
There's a UI bug here - "Admin Settings" is meant to be a heading, but looks like a toggle switch: This is what is used to look like: ![]() I would also remove the We are already recommending all of our customers use this UI section in our docs: https://docs.flagsmith.com/system-administration/authentication/SAML/. Adding another step for self-hosting customers (set up a Flagsmith-on-Flagsmith project and enable this flag) is unnecessary and reduces exposure to this functionality for free self-hosted customers. |
# Conflicts: # frontend/common/constants.ts # frontend/web/components/PermissionsTabs.tsx
@rolodato adjusted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff!
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
Adds a consistent approach to plan based access by adding the following components
Adds a central location for paid features, their plan and their description
Adds a consistent UX based on whether the app is running as SaaS or self-hosted

Adds a video preview to some features, accessible via hovering the feature or on the page depending on the UI.
Testing
Testing, as free self hosted or saas view the following features
2FA

Change Requests
Audit Log

Create 2nd project

Flag owners

RBAC



Stale flag detection

Realtime

Versioning
