Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hide Sensitive Data switch #4199

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Conversation

novakzaballa
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • The 'Hide Sensitive Data' switch now enables and disables correctly.

How did you test this code?

  1. Go to environment settings
  2. Try enabling the 'hide sensitive data' switch.

Copy link

vercel bot commented Jun 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 5:05pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 5:05pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 5:05pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Jun 19, 2024
@novakzaballa novakzaballa requested review from a team and kyle-ssg and removed request for a team June 19, 2024 20:58
@novakzaballa novakzaballa linked an issue Jun 19, 2024 that may be closed by this pull request
4 tasks
Copy link
Contributor

github-actions bot commented Jun 19, 2024

Uffizzi Preview deployment-53256 was deleted.

featureValue={this.state[feature]}
onToggleChange={(value) => {
this.setState({ [feature]: value }, this.saveEnv)
description={'Are you sure that you want to change this value?'}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should ideally explain what the change will do

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how it looks now:

Screenshot 2024-06-20 at 9 20 52 AM

VS Before:

Screenshot 2024-06-20 at 9 27 45 AM

Copy link
Member

@kyle-ssg kyle-ssg Jun 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be in human readable form not snake case.. Also, what does this do? The title is also longer than the description, does not look right at all.

Title : confirm environment setting
Description : this will do xyz, are you sure?

Copy link
Contributor Author

@novakzaballa novakzaballa Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-06-25 at 11 56 16 AM

@kyle-ssg This is the new version

@matthewelwell matthewelwell removed their request for review June 20, 2024 09:47
@novakzaballa novakzaballa added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit ff29f21 Jun 26, 2024
19 checks passed
@novakzaballa novakzaballa deleted the fix/hide-sensitive-data-switch branch June 26, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The 'Hide Sensitive Data' switch isn't working
2 participants