Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Flag update scheduling #4115

Merged
merged 2 commits into from
Jun 5, 2024
Merged

fix: Flag update scheduling #4115

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce8911a
fix: Flag update scheduling
novakzaballa Jun 5, 2024
98b2221
return schedule only when is true
novakzaballa Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions frontend/web/components/saveFeatureWithValidation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export const saveFeatureWithValidation = (cb: () => void) => {
return () => {
export const saveFeatureWithValidation = (cb: (schedule?: boolean) => void) => {
return (schedule: boolean) => {
if (document.getElementById('language-validation-error')) {
openConfirm({
body: 'Your remote config value does not pass validation for the language you have selected. Are you sure you wish to save?',
Expand All @@ -9,7 +9,11 @@ export const saveFeatureWithValidation = (cb: () => void) => {
yesText: 'Save',
})
} else {
cb()
if (schedule) {
cb(schedule)
} else {
cb()
}
}
}
}
Loading