Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(audit): audit and history UI tweaks #4092

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

matthewelwell
Copy link
Contributor

@matthewelwell matthewelwell commented Jun 3, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Tweak small aspects of the UI for Audit / History on an environment feature version. Tweaks as follows:

  1. Add link to view version from audit log detail screen
  2. Always show 'Compare to live' tab option, and simplify render to just show a notice when versions are the same (based on their UUID).
  3. Update the history list page to show an option to view details, as well as quick compare

How did you test this code?

Ran the FE manually against the staging API and verified the changes.

Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 9:36pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 9:36pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 9:36pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Jun 3, 2024
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Uffizzi Preview deployment-52590 was deleted.

@matthewelwell matthewelwell added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit e65dc34 Jun 3, 2024
33 checks passed
@matthewelwell matthewelwell deleted the fix(audit)/audit-and-history-ui-tweaks branch June 3, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants