Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select propagation #4085

Merged
merged 1 commit into from
Jun 3, 2024
Merged

fix: select propagation #4085

merged 1 commit into from
Jun 3, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Jun 3, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Clicking a select element would propagate the event, this is an issue when the parent has a click handler. Prevents the permissions select from opening the permissions modal

image

How did you test this code?

  • Clicked the permissions select.
  • Tested other select elements in the app.

Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 3:57pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 3:57pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 3:57pm

@kyle-ssg kyle-ssg requested a review from rolodato June 3, 2024 15:55
@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Jun 3, 2024
@kyle-ssg kyle-ssg linked an issue Jun 3, 2024 that may be closed by this pull request
4 tasks
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Uffizzi Preview deployment-52573 was deleted.

@kyle-ssg kyle-ssg added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit 0e16068 Jun 3, 2024
21 checks passed
@kyle-ssg kyle-ssg deleted the fix/select-click-propogation branch June 3, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong click target when trying to change role for non-admin user
2 participants