Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add grace period to api usage billing #4038

Merged
merged 2 commits into from
May 28, 2024

Conversation

zachaysan
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Simple change. Adding a criteria to bill API usage overages if they're only over 200% of use.

How did you test this code?

One new test plus existing test coverage.

Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 6:43pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 6:43pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 6:43pm

Copy link
Contributor

github-actions bot commented May 28, 2024

Uffizzi Preview deployment-52358 was deleted.

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (d86f8e7) to head (c0f63f8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4038      +/-   ##
==========================================
- Coverage   96.42%   96.41%   -0.01%     
==========================================
  Files        1145     1145              
  Lines       37330    37348      +18     
==========================================
+ Hits        35994    36010      +16     
- Misses       1336     1338       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachaysan zachaysan added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit 3b61f83 May 28, 2024
22 of 24 checks passed
@zachaysan zachaysan deleted the feat/add_grace_period_to_api_usage_billing branch May 28, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants