-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add endpoint to fetch GitHub repository contributors #4013
Merged
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f46182a
feat: Add endpoint to fetch GitHub repository contributors
novakzaballa 7494e77
test: Add unit test for fetching GitHub repository contributors with …
novakzaballa de79abc
feat: Add PaginatedQueryParamsSerializer for GitHub integration
novakzaballa 1559624
test: Add code coverage
novakzaballa 01204fa
Test: Add test coverage
novakzaballa 086176d
Solve test_fetch_repositories
novakzaballa 3a9c6dc
solve client error
novakzaballa a811fdc
fix: Polish error handling for unit tests
novakzaballa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,44 +1,55 @@ | ||
import typing | ||
from dataclasses import dataclass | ||
from typing import Optional | ||
from dataclasses import dataclass, field | ||
from typing import Any, Optional | ||
|
||
|
||
# Base Dataclasses | ||
@dataclass | ||
class GithubData: | ||
installation_id: str | ||
feature_id: int | ||
feature_name: str | ||
type: str | ||
feature_states: list[dict[str, typing.Any]] | None = None | ||
feature_states: list[dict[str, Any]] | None = None | ||
url: str | None = None | ||
project_id: int | None = None | ||
segment_name: str | None = None | ||
|
||
@classmethod | ||
def from_dict(cls, data_dict: dict[str, typing.Any]) -> "GithubData": | ||
def from_dict(cls, data_dict: dict[str, Any]) -> "GithubData": | ||
return cls(**data_dict) | ||
|
||
|
||
@dataclass | ||
class CallGithubData: | ||
event_type: str | ||
github_data: GithubData | ||
feature_external_resources: list[dict[str, typing.Any]] | ||
feature_external_resources: list[dict[str, Any]] | ||
|
||
|
||
# Dataclasses for external calls to GitHub API | ||
@dataclass | ||
class RepoQueryParams: | ||
class PaginatedQueryParams: | ||
page: int = field(default=1, kw_only=True) | ||
page_size: int = field(default=100, kw_only=True) | ||
|
||
def __post_init__(self): | ||
if self.page < 1: | ||
raise ValueError("Page must be greater or equal than 1") | ||
if self.page_size < 1 or self.page_size > 100: | ||
raise ValueError("Page size must be an integer between 1 and 100") | ||
|
||
|
||
@dataclass | ||
class RepoQueryParams(PaginatedQueryParams): | ||
repo_owner: str | ||
repo_name: str | ||
|
||
|
||
@dataclass | ||
class IssueQueryParams(RepoQueryParams): | ||
search_text: Optional[str] = None | ||
page: Optional[int] = 1 | ||
page_size: Optional[int] = 100 | ||
state: Optional[str] = "open" | ||
author: Optional[str] = None | ||
assignee: Optional[str] = None | ||
search_in_body: Optional[bool] = True | ||
search_in_comments: Optional[bool] = False | ||
|
||
@classmethod | ||
def from_dict(cls, data_dict: dict[str, typing.Any]) -> "RepoQueryParams": | ||
return cls(**data_dict) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: It's not critical, but, since we fully control the creation of this dict, we could add a
TypedDict
return type to this function that would help introspection.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe Dataclass or would it be too much? Let's please discuss this. Merging as is FTM.