Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve the UI/UX for clone identities #3934

Merged
merged 2 commits into from
May 17, 2024
Merged

fix: Improve the UI/UX for clone identities #3934

merged 2 commits into from
May 17, 2024

Conversation

novakzaballa
Copy link
Contributor

@novakzaballa novakzaballa commented May 13, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Change the arrow direction from left to right.
  • Remove unnecessary text when cloning identities.

How did you test this code?

  • Clone Identities in the compare identity tab

@vercel Vercel
Copy link

vercel bot commented May 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 2:12pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 2:12pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 2:12pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label May 13, 2024
@novakzaballa novakzaballa requested review from a team and kyle-ssg and removed request for a team May 13, 2024 21:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 13, 2024 •
edited
Loading

Uffizzi Preview deployment-51664 was deleted.

@kyle-ssg
Copy link
Member

I think as we discussed we should make this "Clone identity overrides" Just to clear up what this is doing

@novakzaballa
Copy link
Contributor Author

I think as we discussed we should make this "Clone identity overrides" Just to clear up what this is doing

Yes, it is cloning identity overrides, but that includes mv identity_overrides. Is something missing or something additional to what was expected?

@novakzaballa
Copy link
Contributor Author

I think as we discussed we should make this "Clone identity overrides" Just to clear up what this is doing

@kyle-ssg According to our conversation, change the text of the "Clone Identity" button to "Clone Identity overrides"

@novakzaballa novakzaballa added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit 48ac76c May 17, 2024
21 checks passed
@novakzaballa novakzaballa deleted the fix/improve-the-ui-ux-for-clone-identities branch May 17, 2024 14:51
@dabeeeenster dabeeeenster mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyle-ssg kyle-ssg kyle-ssg approved these changes

Assignees

@kyle-ssg kyle-ssg

Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@novakzaballa @kyle-ssg