-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Show organisation name in header #3808
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uffizzi Preview |
I remember you mentioned this being confusing in a demo @agregoryfs, might be good to get your opinion. |
I agree there's much better ways to implement this - I submitted this as a low effort stop-gap solution to hopefully prevent someone messing up the wrong organisation until we get a proper design in place. It's a step in the right direction with low risk that we can easily revisit later on. I'll let you guys decide if we want to ship this as-is or wait until we have a better design in place. |
Yeah understood, ok let's do it. @dabeeeenster I wonder if we should get a design prototyped that does something like the above. I do think there are still improvements we should make. The more I compare our navigation to GH (which has very similar hierarchy) the more I think we should bring it closer to that. |
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
Always show the organisation name in the header:
This is what it looks like with very long organisation names:
This ensures users can quickly check which organisation they're working in. This is especially important for self-hosting users and Flagsmith support working within customer organisations.
It also hopefully makes this navigation element more evident as a click target - it's not immediately obvious that "Organisation" is clickable, I've seen a few users miss this.
There's probably a smarter way to implement this, but this was the least offense/effort/risk solution I came up with.
How did you test this code?
Manually, see screenshots.