Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show organisation name in header #3808

Merged
merged 1 commit into from
Apr 19, 2024
Merged

feat: Show organisation name in header #3808

merged 1 commit into from
Apr 19, 2024

Conversation

rolodato
Copy link
Member

@rolodato rolodato commented Apr 18, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Always show the organisation name in the header:

Screenshot 2024-04-18 at 15-38-26 Flagsmith - Feature Flags Feature Toggles and Remote Config

This is what it looks like with very long organisation names:

Screenshot 2024-04-18 at 17 35 40

This ensures users can quickly check which organisation they're working in. This is especially important for self-hosting users and Flagsmith support working within customer organisations.

It also hopefully makes this navigation element more evident as a click target - it's not immediately obvious that "Organisation" is clickable, I've seen a few users miss this.

There's probably a smarter way to implement this, but this was the least offense/effort/risk solution I came up with.

How did you test this code?

Manually, see screenshots.

Copy link

vercel bot commented Apr 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Apr 18, 2024 8:40pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview Apr 18, 2024 8:40pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview Apr 18, 2024 8:40pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Apr 18, 2024
Copy link
Contributor

github-actions bot commented Apr 18, 2024

Uffizzi Preview deployment-50452 was deleted.

@rolodato rolodato marked this pull request as ready for review April 18, 2024 20:48
@rolodato rolodato changed the title feat: Show organisation name in UI feat: Show organisation name in header Apr 18, 2024
@kyle-ssg
Copy link
Member

kyle-ssg commented Apr 19, 2024

I agree it's a bit confusing, to be honest this is the one area I find not quite right about the navigation redesign but I get the rationale was to reduce links in the header.

Having the org name next to the word organisation feels like we're masking something that was just unintuitive to begin with. Do you think that maybe we should consider a breadcrumb here?

As a rough thought, something like this

image

@dabeeeenster dabeeeenster requested a review from kyle-ssg April 19, 2024 08:47
@kyle-ssg
Copy link
Member

I remember you mentioned this being confusing in a demo @agregoryfs, might be good to get your opinion.

@rolodato
Copy link
Member Author

I agree there's much better ways to implement this - I submitted this as a low effort stop-gap solution to hopefully prevent someone messing up the wrong organisation until we get a proper design in place. It's a step in the right direction with low risk that we can easily revisit later on. I'll let you guys decide if we want to ship this as-is or wait until we have a better design in place.

@kyle-ssg
Copy link
Member

kyle-ssg commented Apr 19, 2024

Yeah understood, ok let's do it.

@dabeeeenster I wonder if we should get a design prototyped that does something like the above. I do think there are still improvements we should make. The more I compare our navigation to GH (which has very similar hierarchy) the more I think we should bring it closer to that.

@kyle-ssg kyle-ssg added this pull request to the merge queue Apr 19, 2024
Merged via the queue into main with commit 10b14fd Apr 19, 2024
33 checks passed
@kyle-ssg kyle-ssg deleted the feat/show-org-name branch April 19, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants