fix: edge API not updated when versioned change request committed #3760
Conversation
…environment feature version is committed
matthewelwell
requested review from
a team and
zachaysan
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3760 +/- ##
=======================================
Coverage 95.91% 95.91%
=======================================
Files 1102 1102
Lines 34782 34789 +7
=======================================
+ Hits 33362 33369 +7
Misses 1420 1420 ☔ View full report in Codecov by Sentry. |
| from ...versioning.models import EnvironmentFeatureVersion | ||
| from .exceptions import ( | ||
| from features.workflows.core.exceptions import ( |
There was a problem hiding this comment.
In general I think absolute imports are always fine, but one level of relative imports like from .exceptions import ... are acceptable too. So I agree with your redefinition of from ...versioning.models import EnvironmentFeatureVersion since it's too many levels deep but I don't really see the importance of redefining the exceptions module.
That said, I'm not really hung up on it, I'm more just interested in knowing why you're favouring the absolute import for exceptions here.
There was a problem hiding this comment.
Yeah, that's a fair point. I think I just like standardising to a single approach.
| rebuild_environment_document.delay( | ||
| kwargs={"environment_id": self.environment_id}, | ||
| delay_until=environment_feature_version.live_from, | ||
| ) |
There was a problem hiding this comment.
Just to confirm: The live_from of the environment feature version could be well into the future, correct? But that's ok since our task system is designed to handle it? Just confirming we'd survive, say, a task scheduled further in the future to survive a backend deployment or similar.
There was a problem hiding this comment.
Yep, it's persisted to the postgres database.
matthewelwell
deleted the
fix/ensure-ddb-rebuild-on-versioned-change-request
branch
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Adds logic to trigger the
rebuild_environment_taskwhen a change request containing environment feature version objects is committed.This PR also includes some minor tidying up of imports to remove ugly relative imports.
How did you test this code?
Updated existing unit test.