Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect environment variable interpolation in Makefile #3709

Merged
merged 1 commit into from
Apr 2, 2024
Merged

fix: Incorrect environment variable interpolation in Makefile #3709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/.env-ci
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
DATABASE_URL=postgresql://postgres:postgres@localhost:5432/postgres
ANALYTICS_DATABASE_URL=postgres://postgres:postgres@localhost:5432/analytics
PYTEST_ADDOPTS=--cov . --cov-report xml -n auto --dist worksteal

GUNICORN_LOGGER_CLASS=util.logging.GunicornJsonCapableLogger
3 changes: 2 additions & 1 deletion api/.env-local
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
DATABASE_URL=postgresql://postgres:password@localhost:5432/flagsmith
DJANGO_SETTINGS_MODULE=app.settings.local
PYTEST_ADDOPTS=--cov . --cov-report html -n auto
PYTEST_ADDOPTS=--cov . --cov-report html -n auto
GUNICORN_LOGGER_CLASS=util.logging.GunicornJsonCapableLogger
2 changes: 1 addition & 1 deletion api/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ django-collect-static:
.PHONY: serve
serve:
poetry run gunicorn --bind 0.0.0.0:8000 \
--logger-class ${GUNICORN_LOGGER_CLASS:-'util.logging.GunicornJsonCapableLogger'} \
--logger-class ${GUNICORN_LOGGER_CLASS} \
--reload \
app.wsgi

Expand Down