Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: database Compose warnings and set a project name #3701

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

rolodato
Copy link
Member

@rolodato rolodato commented Apr 1, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fixes two warnings when launching the database from Docker Compose:

% docker --version
Docker version 26.0.0, build 2ae903e86c
% docker compose -f db.yml up
WARN[0000] /Users/rolodato/source/flagsmith/flagsmith/docker/db.yml: `version` is obsolete
[+] Running 1/1
 ✔ db Pulled                                                                                                   1.6s
WARN[0001] mount of type `volume` should not define `bind` option
[+] Running 0/1
 ⠋ Container docker-db-1  Created                                                                              0.0s
Attaching to db-1
[...]

Also, this PR adds a top-level name field to the Compose file. Otherwise, the default project name is docker (the directory name where the Compose file lives), which is not very informative.

Before:

image

After:

image

More details on the top-level version and name Compose field names: https://docs.docker.com/compose/compose-file/04-version-and-name/

How did you test this code?

Manually tested by starting the database using Compose as usual:

docker compose -f docker/db.yml up

rolodato added 3 commits April 1, 2024 10:37
Fixes this warning when creating the db container:

    WARN[0001] mount of type `volume` should not define `bind` option
Copy link

vercel bot commented Apr 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2024 1:55pm

Copy link

vercel bot commented Apr 1, 2024

Someone is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

@rolodato rolodato changed the title Fix database Compose warnings and set a project name fix: database Compose warnings and set a project name Apr 1, 2024
@rolodato rolodato added this pull request to the merge queue Apr 2, 2024
Merged via the queue into Flagsmith:main with commit 93ace86 Apr 2, 2024
19 of 21 checks passed
@rolodato rolodato deleted the compose-warnings-project-name branch April 2, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants