Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove user override #3559

Merged
merged 4 commits into from
Mar 13, 2024
Merged

chore: Remove user override #3559

merged 4 commits into from
Mar 13, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Mar 6, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Allows you to remove user overrides from the feature modal
Screen.Recording.2024-03-06.at.11.28.29.mov

How did you test this code?

Please describe.

@kyle-ssg kyle-ssg requested a review from novakzaballa March 6, 2024 11:30
@vercel Vercel
Copy link

vercel bot commented Mar 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 0:13am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 0:13am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 0:13am

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Mar 6, 2024
@kyle-ssg kyle-ssg linked an issue Mar 6, 2024 that may be closed by this pull request
No way to remove accidentally added identity overrides #3502
Closed
novakzaballa
novakzaballa approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dabeeeenster
Copy link
Contributor

Need to fix the rebase

@matthewelwell
Merge branch 'main' into chore/remove-user-override
6ff5711 
# Conflicts:
#	frontend/web/components/pages/UserPage.js
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 12, 2024 •
edited
Loading

Uffizzi Preview deployment-48260 was deleted.

kyle-ssg added 2 commits March 13, 2024 12:05
@kyle-ssg
Merge branch 'main' into chore/remove-user-override
1e85a42 
# Conflicts:
#	frontend/web/components/pages/UserPage.js
@kyle-ssg
Merge remote-tracking branch 'origin/chore/remove-user-override' into…
2325df2 
… chore/remove-user-override
@kyle-ssg kyle-ssg added this pull request to the merge queue Mar 13, 2024
Merged via the queue into main with commit 3838f83 Mar 13, 2024
11 of 20 checks passed
@kyle-ssg kyle-ssg deleted the chore/remove-user-override branch March 13, 2024 12:07
@kyle-ssg kyle-ssg mentioned this pull request Mar 13, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novakzaballa novakzaballa novakzaballa approved these changes

Assignees

@kyle-ssg kyle-ssg

Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No way to remove accidentally added identity overrides
4 participants
@kyle-ssg @dabeeeenster @novakzaballa @matthewelwell