-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enabled state filter (Frontend) #3542
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uffizzi Preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good thus far, but just wanted to confirm that we're designing in a search field as well to match feature values based on boolean, string, and integer values.
It’s an easy addition but I couldn’t imagine that common a use case , thinking about itI’ll do it as part of this pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, but please hold off on merging this until the server issue you highlighted gets fixed.
Edit: Or wrap this all up under a feature flag so we can deploy and fix whenever we want.
Yep its under a feature flag. |
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
Frontend functionality for filtering feature enabled state and feature value, based on #3541. This is controlled by the feature flag feature_enabled_state_filter.
Note: I believe the API is searching based on the project default_value/default_enabled, it should be based on the provided environment's feature state. We'd never want to filter based on defaults.
How did you test this code?