feat: add option to disable secure cookies and configure samesite
#3441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
front-end
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3441 +/- ##
=======================================
Coverage 95.91% 95.91%
=======================================
Files 1092 1092
Lines 34003 34005 +2
=======================================
+ Hits 32613 32615 +2
Misses 1390 1390 ☔ View full report in Codecov by Sentry. |
kyle-ssg
approved these changes
Feb 20, 2024
matthewelwell
changed the title
samesite
matthewelwell
force-pushed
the
feat/add-option-to-disable-secure-cookies
branch
from
9ebe844 to
22249a5
Compare
kyle-ssg
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Adds an environment variables to disable using secure cookies and configuring the value of
samesite. This is to be used for deployments inside a private network without a domain / ssl cert.How did you test this code?
Used a combination of
SAME_SITE_COOKIE: strictandUSE_SECURE_COOKIES: falseto confirm that running the Flagsmith application over http on an internal IP address correctly sets the token. Note that the defaults are set to the same as the previous values.