feat: Add has expired column in the api keys table #3433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
front-end
|
Uffizzi Preview |
|
Is there anything we can do to make this look a bit nicer? 
Perhaps expired isn't the correct data point here, maybe we should have an 'active' column which just includes a tick / cross and add a tooltip explaining if it's because it has expired? |
Yes, those are good ideas, I'll make those changes. |
Hey @matthewelwell I already made the changes, it looks like the image above.
|
Can we align things / make things consistent. The active badge should probably be green, right? |
Done |
| <div className='ml-1'> | ||
| <Tooltip title={<Icon name='close-circle' />}> | ||
| { | ||
| 'This API key has expired due to reaching its expiration date' |
There was a problem hiding this comment.
Suggested change
| 'This API key has expired due to reaching its expiration date' | |
| 'This API key has expired' |
matthewelwell
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
How did you test this code?