Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Versioning test - always login regardless of skip test #3424

Merged
merged 2 commits into from
Feb 15, 2024
Merged

fix: Versioning test - always login regardless of skip test #3424

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
500946c
Always login regardless of skip test
kyle-ssg Feb 15, 2024
825ee43
Use log rather than console log
kyle-ssg Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/e2e/tests/versioning-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ import Project from '../../common/project';
export default async () => {
await flagsmith.init({fetch,environmentID:Project.flagsmith,api:Project.flagsmithClientAPI})
const hasFeature = flagsmith.hasFeature("feature_versioning")
log('Login')
await login(E2E_USER, PASSWORD)
if(!hasFeature) {
console.log("Skipping version test, feature not enabled.")
return
}

log('Login')
await login(E2E_USER, PASSWORD)
await createOrganisationAndProject('Flagsmith Versioning Org', 'Flagsmith Versioning Project')
await waitForElementVisible(byId('features-page'))
await click('#env-settings-link')
Expand Down
Loading