Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Solve flag and segments flaky tests #3399

Closed
wants to merge 1 commit into from

Conversation

novakzaballa
Copy link
Contributor

@novakzaballa novakzaballa commented Feb 7, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Please describe.

How did you test this code?

Please describe.

Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 9:59pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 9:59pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 9:59pm

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Uffizzi Ephemeral Environment deployment-46136

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/3399

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@Dogacel Dogacel mentioned this pull request Feb 7, 2024
5 tasks
@novakzaballa novakzaballa changed the title test: Solve flag and segments flaky tests WIP test: Solve flag and segments flaky tests Mar 25, 2024
@kyle-ssg
Copy link
Member

image

Does this suggest the flakiness has not been solved?

@@ -295,6 +295,10 @@ export const createFeature = async (
description = 'description',
) => {
await gotoFeatures()
await t.eval(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, what's the theory behind this solving issues with e2e ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That function will scroll down the screen. One issue is that I was trying to click on a component that wasn't visible.

@novakzaballa
Copy link
Contributor Author

image

Does this suggest the flakiness has not been solved?

@kyle-ssg This is another flaky issue. The problem here is that, for some reason, the ID 'email' was not found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants