-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Solve flag and segments flaky tests #3399
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uffizzi Ephemeral Environment
|
@@ -295,6 +295,10 @@ export const createFeature = async ( | |||
description = 'description', | |||
) => { | |||
await gotoFeatures() | |||
await t.eval(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, what's the theory behind this solving issues with e2e ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That function will scroll down the screen. One issue is that I was trying to click on a component that wasn't visible.
@kyle-ssg This is another flaky issue. The problem here is that, for some reason, the ID 'email' was not found. |
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
Please describe.
How did you test this code?
Please describe.