Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redis_cache): Create SafeRedisClusterClient class to avoid application crashing because of redis #3391

Closed
wants to merge 1 commit into from

Conversation

gagantrivedi
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Create a client class that converts RedisClusterException to ConnectionInterrupted(handled/defined by django_redis)
  • Add explicit retry

How did you test this code?

  • Adds unit tests
  • Tested manually against local redis cluster

Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Feb 7, 2024 6:05am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview Feb 7, 2024 6:05am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview Feb 7, 2024 6:05am

@github-actions github-actions bot added the api Issue related to the REST API label Feb 7, 2024
@gagantrivedi
Copy link
Member Author

closing for #3392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant