Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(task-processor): add Task Processor inputs as env vars #3355

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

matthewelwell
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Adds the inputs to the Task Processor as environment variables in the run-docker.sh script. Resolves #3317.

How did you test this code?

Ran the task processor locally using this script, setting each of the variables.

This command

LOG_LEVEL=DEBUG TASK_PROCESSOR_SLEEP_INTERVAL=10000 TASK_PROCESSOR_QUEUE_POP_SIZE=20 TASK_PROCESSOR_GRACE_PERIOD_MS=100000 TASK_PROCESSOR_NUM_THREADS=1 ./scripts/run-docker.sh run-task-processor

Resulted in the following log message in the console:

task_processor.management.commands.runprocessor DEBUG    Running task processor with args: verbosity=1,settings=None,pythonpath=None,traceback=False,no_color=False,force_color=False,skip_checks=False,numthreads=1,sleepintervalms=10000,graceperiodms=100000,queuepopsize=20

Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 10:36am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 10:36am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 10:36am

@matthewelwell matthewelwell changed the title Add Task Processor inputs as env vars feat(task-processor) add Task Processor inputs as env vars Jan 31, 2024
@github-actions github-actions bot added the api Issue related to the REST API label Jan 31, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (31af594) 95.94% compared to head (074d30d) 18.00%.
Report is 7 commits behind head on main.

Files Patch % Lines
...task_processor/management/commands/runprocessor.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3355       +/-   ##
===========================================
- Coverage   95.94%   18.00%   -77.94%     
===========================================
  Files        1067      990       -77     
  Lines       32621    28562     -4059     
===========================================
- Hits        31298     5143    -26155     
- Misses       1323    23419    +22096     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell changed the title feat(task-processor) add Task Processor inputs as env vars feat(task-processor): add Task Processor inputs as env vars Jan 31, 2024
@matthewelwell matthewelwell requested review from a team and zachaysan and removed request for a team January 31, 2024 09:38
Copy link
Contributor

github-actions bot commented Jan 31, 2024

Uffizzi Preview deployment-45463 was deleted.

@matthewelwell matthewelwell added this pull request to the merge queue Feb 2, 2024
Merged via the queue into main with commit 789898c Feb 2, 2024
21 checks passed
@matthewelwell matthewelwell deleted the feat/add-task-processor-inputs branch February 2, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants