-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datadog): add source type name to datadog #3342
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3342 +/- ##
=======================================
Coverage 95.91% 95.91%
=======================================
Files 1085 1086 +1
Lines 33677 33692 +15
=======================================
+ Hits 32302 32317 +15
Misses 1375 1375 ☔ View full report in Codecov by Sentry. |
Uffizzi Preview |
1c0d7c1
to
c178a55
Compare
@kyle-ssg I've just retested this in the Uffizzi environment and it's not working. I'm sure that it previously was sending the correct data, but it seems like it's no longer doing so - I can't quite see why though. This should include the ![]() |
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
Adds the
source_type_name
attribute to requests to the datadog request to display the source in the datadog dashboard as per documentation here.How did you test this code?
Modified / added tests. Also made a manual call to the datadog API with the source_type_name parameter set to "flagsmith" to verify it was accepted (as you can see in screenshot below)
I also ran the FE locally to verify that the changes made in the
CreateEditIntegration
component work as expected.