fix(2079/deadlock): avoid deadlock by updating env individually #3339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gagantrivedi
requested review from
a team,
khvn26 and
matthewelwell
and removed request for
a team
khvn26
approved these changes
Jan 29, 2024
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3339 +/- ##
===========================================
- Coverage 95.95% 50.85% -45.10%
===========================================
Files 1067 1001 -66
Lines 32673 29527 -3146
===========================================
- Hits 31350 15015 -16335
- Misses 1323 14512 +13189 ☔ View full report in Codecov by Sentry. |
matthewelwell
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
As documented here the cause of the deadlock was this where clause
.... where project_id=<>. This PR avoids that by updating theupdated_atfor every environment individually, i.e:...where environment_id=<>Note: the duplicate signals issue is not relevant any more because we exclude
updated_atfrom historical trackingHow did you test this code?
I attempted to reproduce this on staging by updating segments for a project using
wrk(10 threads, 10 connections), but I could not. However, based on reasoning, this should work.