Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Project usage limits #3338

Closed

Conversation

fabricanva
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • The limits and current usage have been added to the Project and Environment settings pages.
  • If it reaches 90%, it will be displayed in yellow, and if it reaches or exceeds the limit, it will be marked in red.
  • A link to the documentation regarding the limits of these entities has been added.
  • A style issue for the 'Create Your First Segment' icon on the segments page has been resolved
Screen Shot 2024-01-29 at 00 52 18 Screen Shot 2024-01-29 at 02 39 27 Screen Shot 2024-01-29 at 00 47 35

Before:
Screen Shot 2024-01-29 at 03 42 54
After:
Screen Shot 2024-01-29 at 03 44 27

How did you test this code?

  • The feature and segment limits can be viewed on the project's Settings screen under the General tab.
  • The segment overrides can be viewed on the environment's Settings screen.

Copy link

vercel bot commented Jan 29, 2024

@fabricanva is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 7:52am

@kyle-ssg
Copy link
Member

kyle-ssg commented Feb 7, 2024

Hey @fabricanva, thank you for this! If I'm not mistaken, I believe this duplicates the effort done in this open PR please advise if this is not the case though.

@novakzaballa novakzaballa removed their request for review February 9, 2024 13:10
@matthewelwell
Copy link
Contributor

Hi @fabricanva, thanks again for this contribution but as @kyle-ssg mentioned, there is an outstanding PR for this already. Please let me know if you'd like another issue to work on and I can try and find one for you. Thanks!

@fabricanva
Copy link
Contributor Author

@matthewelwell No problem, yes, I see that there was already another PR related to this issue, I will look for another one, thank you for the response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants