Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: default task processor to use TaskRunMethod.TASK_PROCESSOR #3272

Closed

Conversation

matthewelwell
Copy link
Contributor

Changes

This PR updates the default value of the TASK_RUN_METHOD setting such that the task processor should always default to using the task processor itself, for any asynchronous invocations inside the tasks themselves.

How did you test this code?

In staging, we noticed that the changes made in this PR did not work as expected, since the tasks were run in a separate thread, not scheduled for the task processor. We will retest this behaviour in staging once this PR is merged.

Ran the processor locally and confirmed that the TASK_RUN_METHOD setting was correctly set to TASK_PROCESSOR when RUN_BY_PROCESSOR=True.

Ran the API locally and confirmed that the TASK_RUN_METHOD setting was correctly defaulted to SEPARATE_THREAD when RUN_BY_PROCESSOR=False

Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 11:29am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview Jan 11, 2024 11:29am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 11:29am

@github-actions github-actions bot added the api Issue related to the REST API label Jan 11, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 58 lines in your changes are missing coverage. Please review.

Comparison is base (6500451) 95.95% compared to head (70a4eaa) 17.85%.
Report is 10 commits behind head on main.

Files Patch % Lines
...ature_segments/test_unit_feature_segments_views.py 0.00% 23 Missing ⚠️
...pi/tests/unit/features/test_unit_features_views.py 0.00% 15 Missing ⚠️
...sioning/test_unit_versioning_versioning_service.py 0.00% 8 Missing ⚠️
api/features/feature_segments/views.py 0.00% 6 Missing ⚠️
api/features/versioning/versioning_service.py 66.66% 1 Missing ⚠️
...ronments/identities/test_integration_identities.py 0.00% 1 Missing ⚠️
...ities/test_unit_identities_feature_states_views.py 0.00% 1 Missing ⚠️
...nts/test_unit_environments_feature_states_views.py 0.00% 1 Missing ⚠️
.../unit/environments/test_unit_environments_views.py 0.00% 1 Missing ⚠️
...ts/unit/features/test_unit_features_permissions.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3272       +/-   ##
===========================================
- Coverage   95.95%   17.85%   -78.10%     
===========================================
  Files        1067      988       -79     
  Lines       32649    28663     -3986     
===========================================
- Hits        31327     5119    -26208     
- Misses       1322    23544    +22222     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 11, 2024

Uffizzi Preview deployment-44177 was deleted.

@matthewelwell matthewelwell deleted the chore/default-task-processor-to-use-processor branch January 11, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants