Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: audit log details #3264

Merged
merged 9 commits into from
Jan 11, 2024
Merged

chore: audit log details #3264

merged 9 commits into from
Jan 11, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Jan 10, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Adds an audit log details page in order to show changes under the feature flag audit_log_detail.

image

image

How did you test this code?

Viewed audit logs on staging

@vercel Vercel
Copy link

vercel bot commented Jan 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 4:57pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 4:57pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 4:57pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Jan 10, 2024
@kyle-ssg kyle-ssg changed the title Chore/audit log details chore: audit log details Jan 10, 2024
@kyle-ssg kyle-ssg marked this pull request as draft January 10, 2024 13:15
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024 •
edited
Loading

Uffizzi Preview deployment-44090 was deleted.

@kyle-ssg kyle-ssg marked this pull request as ready for review January 10, 2024 13:53
@kyle-ssg kyle-ssg linked an issue Jan 10, 2024 that may be closed by this pull request
Add change details to audit log #1347
Closed
@kyle-ssg
Merge branch 'chore/diff-change-requests' into chore/audit-log-details
cbc8ab7 
# Conflicts:
#	frontend/common/types/requests.ts
novakzaballa
novakzaballa approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyle-ssg kyle-ssg merged commit dc95eef into chore/diff-change-requests Jan 11, 2024
@kyle-ssg kyle-ssg deleted the chore/audit-log-details branch January 11, 2024 09:47
@novakzaballa novakzaballa mentioned this pull request Jan 12, 2024
Merged
5 tasks
@matthewelwell
Copy link
Contributor

Trying to test this in production now but I'm not sure it's working.

audit_log_detail.mov

@kyle-ssg kyle-ssg mentioned this pull request Jan 31, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novakzaballa novakzaballa novakzaballa approved these changes

@matthewelwell matthewelwell Awaiting requested review from matthewelwell

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add change details to audit log
3 participants
@kyle-ssg @matthewelwell @novakzaballa