feat: add fields necessary for stale flags #3263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3263 +/- ##
===========================================
- Coverage 95.95% 76.68% -19.27%
===========================================
Files 1067 1043 -24
Lines 32649 32135 -514
===========================================
- Hits 31327 24644 -6683
- Misses 1322 7491 +6169 ☔ View full report in Codecov by Sentry. |
matthewelwell
force-pushed
the
feat/stale-flags
branch
from
f0066f2 to
5449bb5
Compare
matthewelwell
changed the title
khvn26
reviewed
Feb 7, 2024
api/projects/tags/migrations/0005_add_tag_fields_for_stale_flags_logic.py
Show resolved
Hide resolved
|
The code looks fine, but I felt I needed some questions cleared up for me before approving it. |
khvn26
approved these changes
Feb 9, 2024
matthewelwell
force-pushed
the
feat/stale-flags
branch
from
5808181 to
7226ced
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds logic necessary to support the stale flags functionality. The relevant changes are:
a.
is_system_tag- field denoting that the tag is system created, rather than user created (necessary for the tag we plan to add to any flags determined to be stale)b.
is_permanent- a replacement for the current FE functionality which uses regex to determine if a tag indicates that a feature is 'permanent' and should not be deleted. This is necessary as we will ignore any features tagged with a tag that has this attribute when evaluating if a feature is stale or not.c.
type- a field to add a new enumerated 'type' field to a tag. This allows us to deterministically find the tag which indicates a feature is stale.Note that there is a related PR in the workflows repository here which adds the relevant tasks, etc. to supplement these changes.
How did you test this code?
Added unit tests.