Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Display identity override badges #3177

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Dec 18, 2023

This reverts commit 6a44b3d.

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Merge after #[3164] is released.

This reverts identity override badges removal in frontend. The logic for displaying them will be on the backend side as per changes in #3164.

How did you test this code?

Ran locally, observed the badges near feature names for for Edge projects.

@khvn26 khvn26 requested a review from matthewelwell December 18, 2023 13:43
Copy link

vercel bot commented Dec 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 11:12am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 11:12am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 11:12am

Copy link
Contributor

github-actions bot commented Dec 18, 2023

Uffizzi Preview deployment-43078 was deleted.

Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but this should NOT be merged until this PR has been deployed to production.

Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again following change to open correct tab. Tested manually using preview link.

Also, confirming that 2.89.0 included required API changes and has been released.

@khvn26 khvn26 added this pull request to the merge queue Dec 19, 2023
Merged via the queue into main with commit a42ae58 Dec 19, 2023
@khvn26 khvn26 deleted the chore/enable-identity-override-count-badge branch December 19, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants