Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dockerfile): setup gnupg correctly for nobody #3167

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Dec 14, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Make nobody owner of .gnupg
  • pass gnupghome to GPG

How did you test this code?

By deploying in staging and verifying that the data in influx is available

Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 14, 2023 1:30pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview Dec 14, 2023 1:30pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview Dec 14, 2023 1:30pm

@github-actions github-actions bot added the api Issue related to the REST API label Dec 14, 2023
Copy link
Contributor

github-actions bot commented Dec 14, 2023

Uffizzi Preview deployment-42828 was deleted.

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c475e4) 96.11% compared to head (ca6146e) 96.08%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3167      +/-   ##
==========================================
- Coverage   96.11%   96.08%   -0.04%     
==========================================
  Files        1058     1059       +1     
  Lines       31918    32534     +616     
==========================================
+ Hits        30677    31259     +582     
- Misses       1241     1275      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi marked this pull request as ready for review December 15, 2023 04:39
@gagantrivedi gagantrivedi requested review from a team and khvn26 and removed request for a team December 15, 2023 04:43
@gagantrivedi gagantrivedi added this pull request to the merge queue Dec 15, 2023
Merged via the queue into main with commit 4759876 Dec 15, 2023
@gagantrivedi gagantrivedi deleted the fix-gnupg-setup branch December 15, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants