Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add dunning banner #3114

Merged
merged 3 commits into from
Dec 8, 2023
Merged

feat: Add dunning banner #3114

merged 3 commits into from
Dec 8, 2023

Conversation

novakzaballa
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Add dunning banner when the billing status is DUNNING
  • Wrapped with show_dunning_banner flag

How did you test this code?

  • Change an Organisation's billing status from ACTIVE to DUNNING
  • Log in Flagsmith app with an Organisation user

@vercel Vercel
Copy link

vercel bot commented Dec 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2023 5:18pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2023 5:18pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2023 5:18pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Dec 7, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023 •
edited
Loading

Uffizzi Preview deployment-42376 was deleted.

@novakzaballa novakzaballa linked an issue Dec 7, 2023 that may be closed by this pull request
Handle dunning accounts in a more proactive way #1822
Closed
2 tasks
@dabeeeenster dabeeeenster requested a review from kyle-ssg December 8, 2023 11:26
zachaysan
zachaysan approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@zachaysan zachaysan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but I'd change the wording a bit to make it more natural.

@novakzaballa novakzaballa added this pull request to the merge queue Dec 8, 2023
Merged via the queue into main with commit ad26100 Dec 8, 2023
@novakzaballa novakzaballa deleted the feat/add-dunning-banner branch December 8, 2023 17:21
@dabeeeenster dabeeeenster mentioned this pull request Dec 8, 2023
Merged
@dabeeeenster dabeeeenster mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachaysan zachaysan zachaysan approved these changes

@kyle-ssg kyle-ssg kyle-ssg approved these changes

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle dunning accounts in a more proactive way
3 participants
@novakzaballa @zachaysan @kyle-ssg