fix: resolve environment N+1 caused by feature versioning v2 #3040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3040 +/- ##
=======================================
Coverage 95.73% 95.73%
=======================================
Files 1046 1044 -2
Lines 30859 30866 +7
=======================================
+ Hits 29544 29551 +7
Misses 1315 1315 ☔ View full report in Codecov by Sentry. |
matthewelwell
force-pushed
the
fix/environments-n+1
branch
from
ca17054 to
0d7a33d
Compare
matthewelwell
requested review from
a team and
gagantrivedi
and removed request for
a team
khvn26
approved these changes
Nov 27, 2023
matthewelwell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Caused by the addition of this line in the feature versioning V2, this PR resolves an N+1 query issue retrieving the environment.
Note, this adds a test to the old location to keep things grouped for now but should be moved to the new location asap.
How did you test this code?
Added a test to reproduce the N+1 error before resolving.