Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Close icon missing in roles modal #2946

Merged
merged 1 commit into from
Nov 9, 2023
Merged

fix: Close icon missing in roles modal #2946

merged 1 commit into from
Nov 9, 2023

Conversation

novakzaballa
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Add Close Icons in the edit role modal

@vercel Vercel
Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Nov 8, 2023 8:39pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview Nov 8, 2023 8:39pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview Nov 8, 2023 8:39pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Nov 8, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023 •
edited
Loading

Uffizzi Preview deployment-40353 was deleted.

@novakzaballa novakzaballa requested review from a team and gagantrivedi November 8, 2023 22:07
@novakzaballa novakzaballa added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit 4960f7e Nov 9, 2023
@novakzaballa novakzaballa deleted the fix/close-icon-missing-in-roles-modal branch November 9, 2023 02:26
@dabeeeenster dabeeeenster mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gagantrivedi gagantrivedi gagantrivedi approved these changes

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@novakzaballa @gagantrivedi