Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(edge-identity-view): reduce max page size to 100 #2937

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Nov 8, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Reduce max page size to improve latency
refer: https://github.com/Flagsmith/infrastructure/issues/16

How did you test this code?

Covered by unit tests

Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Nov 8, 2023 3:37am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview Nov 8, 2023 3:37am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview Nov 8, 2023 3:37am

@github-actions github-actions bot added the api Issue related to the REST API label Nov 8, 2023
@gagantrivedi gagantrivedi requested a review from a team November 8, 2023 03:37
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Uffizzi Preview deployment-40269 was deleted.

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3732e67) 95.63% compared to head (0dd666b) 95.63%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2937   +/-   ##
=======================================
  Coverage   95.63%   95.63%           
=======================================
  Files        1012     1012           
  Lines       29137    29142    +5     
=======================================
+ Hits        27866    27871    +5     
  Misses       1271     1271           
Files Coverage Δ
api/app/pagination.py 92.59% <100.00%> (+0.59%) ⬆️
api/environments/dynamodb/dynamodb_wrapper.py 96.03% <100.00%> (+0.03%) ⬆️
...s/dynamodb/tests/test_dynamodb_identity_wrapper.py 98.22% <100.00%> (+0.01%) ⬆️
.../edge_api/identities/test_edge_identity_viewset.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zachaysan zachaysan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@matthewelwell
Copy link
Contributor

I have sent notifications out that this will be released on Tuesday 21st November.

@gagantrivedi gagantrivedi added this pull request to the merge queue Nov 21, 2023
Merged via the queue into main with commit 6c4807f Nov 21, 2023
@gagantrivedi gagantrivedi deleted the fix/edge-identity/reduce-max-page-size branch November 21, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants