Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Click Segment Overrides icon doesnt open the segment override tab #2887

Merged
merged 1 commit into from
Oct 25, 2023
Merged

feat: Click Segment Overrides icon doesnt open the segment override tab #2887

merged 1 commit into from
Oct 25, 2023

Conversation

novakzaballa
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • When clicking the Segment Overrides Icon in a feature row this opens the segment override tab
Screen Shot 2023-10-24 at 18 14 35 Screen Shot 2023-10-24 at 18 15 49

How did you test this code?

  • Go to Features page
  • Click Segment overrides Icon

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Oct 25, 2023 1:42pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview Oct 25, 2023 1:42pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview Oct 25, 2023 1:42pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Oct 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023 •
edited
Loading

Uffizzi Preview deployment-39408 was deleted.

@novakzaballa novakzaballa linked an issue Oct 25, 2023 that may be closed by this pull request
Clicking on the Segment Overrides icon doesn't open the segment override tab #2882
Closed
4 tasks
@novakzaballa novakzaballa requested review from a team and matthewelwell October 25, 2023 14:23
matthewelwell
matthewelwell reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good from a functionality point of view but I've added one comment to the implementation.

@matthewelwell matthewelwell added this pull request to the merge queue Oct 25, 2023
Merged via the queue into main with commit 96f3b22 Oct 25, 2023
@matthewelwell matthewelwell deleted the feat/click-segment-overrides-icon-doesnt-open-the-segment-override-tab branch October 25, 2023 14:51
@dabeeeenster dabeeeenster mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clicking on the Segment Overrides icon doesn't open the segment override tab
2 participants
@novakzaballa @matthewelwell