feat: Add metadata fields to core entities #2861

novakzaballa · 2023-10-18T22:18:03Z

Thanks for submitting a PR! Please check the boxes below:

I have run pre-commit to check linting
I have filled in the "Changes" section below?
I have filled in the "How did you test this code" section below?
I have used a Conventional Commit title for this Pull Request

Changes

FE changes:

Add and create metadata to Environments, segments, and Flags
The feature was wrapped inside the 'enable_metadata' flag
BE changes:
Support metadata for segments, and Flags
Support required metadata model fields for segments, and Flags

How did you test this code?

Go to manage
Click the Metadata tab.
Create Metadata.
Edit metadata and enable any entity

vercel · 2023-10-18T22:18:10Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 21, 2023 6:05pm
flagsmith-frontend-preview	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 21, 2023 6:05pm
flagsmith-frontend-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 21, 2023 6:05pm

novakzaballa · 2023-12-18T13:45:14Z

I think this needs to go to design or at least more closely use the design system, e.g. making these column items checkboxes rather than the current ui and a less wordy edit cta.

I made some changes.

Do we explain what "Metadata" is where the user can create it ? Maybe a subtitle and a link to docs would be useful here.

I put a metadata subtitle, in the sections "managing features", "managing segments" and "environment settings" inside the docs.

kyle-ssg · 2023-12-18T14:43:09Z

frontend/web/components/MetadataSelect.tsx

+      title='Metadata'
+      isOpen={isOpen}
+      onClose={onToggle}
+      className='inline-modal--tags'


Can this be replaced with inline-modal--sm

kyle-ssg · 2023-12-18T14:43:43Z

frontend/web/components/MetadataSelect.tsx

+        className='full-width mb-2'
+        placeholder='Type or choose a Metadata'
+      />
+      <div style={{ maxHeight: 200, overflowY: 'auto' }}>


Can the inline style be replaced with className="inline-modal__list"

kyle-ssg · 2023-12-18T14:44:39Z

frontend/web/components/MetadataSelect.tsx

+        placeholder='Type or choose a Metadata'
+      />
+      <div style={{ maxHeight: 200, overflowY: 'auto' }}>
+        {metadataList &&


What if there are none? Should display a default message

metadataList?.length? () : (<div className="text-center">No items</div>)

kyle-ssg · 2023-12-18T14:46:32Z

frontend/web/components/MetadataSelect.tsx

+                space
+              >
+                <Flex
+                  className={value?.includes(v.id) ? 'font-weight-bold' : ''}


If possible can we rename and reuse TableFilterItem.tsx? It does the exact same as this.

kyle-ssg · 2023-12-18T14:47:16Z

frontend/web/components/MyMetadataSelect.tsx

@@ -0,0 +1,37 @@
+import { FC, useEffect, useState } from 'react'


Is there a reason why it's called MyMetadata, that would indicate to me it's specific to the user but I think this is for the org?

kyle-ssg · 2023-12-18T14:48:43Z

frontend/web/components/modals/CreateFlag.js

+                              <span className='chip-icon ion'>
+                                <IonIcon
+                                  icon={closeIcon}
+                                  style={{ fontSize: '13px' }}


className="fs-caption"

kyle-ssg · 2023-12-18T14:50:44Z

frontend/web/components/pages/ProjectSettingsPage.js

+                                      width: '185px',
+                                    }}
+                                  >
+                                    <div className='table-column'>


Markup here doesn't lookl correct, we are nesting table-column elements. Please lets use classnames where possible too.

<div className='table-column d-flex text-center'>

kyle-ssg · 2023-12-18T14:52:06Z

frontend/web/components/pages/ProjectSettingsPage.js

+                                    }}
+                                  >
+                                    <div className='table-column'>
+                                      {metadata.content_type_fields.find(


Hard to read what the following functions are doing, perhaps separate these into variables above the markup ?

kyle-ssg · 2023-12-18T14:52:52Z

frontend/web/components/pages/ProjectSettingsPage.js

+                                      className='table-column'
+                                      style={{ width: '150px' }}
+                                    >
+                                      {metadata.content_type_fields.find(


kyle-ssg · 2023-12-18T14:52:59Z

frontend/web/components/pages/ProjectSettingsPage.js

+                                      }}
+                                    >
+                                      {metadata.content_type_fields.find(
+                                        (m) =>


novakzaballa added 2 commits October 13, 2023 11:54

feat: Add metadata fields to core entities

f41c8d5

feat: Add metadata model field

e1bc9ec

github-actions bot added the front-end Issue related to the React Front End Dashboard label Oct 18, 2023

Add metadata to environments and segments

930c9c8

github-actions bot added the api Issue related to the REST API label Oct 19, 2023

vercel bot deployed to Preview – flagsmith-frontend-preview October 19, 2023 18:54 View deployment

vercel bot deployed to Preview – docs October 19, 2023 18:55 View deployment

vercel bot deployed to Preview – flagsmith-frontend-staging October 19, 2023 18:57 View deployment

Solve error with metadataselect

625e331

vercel bot deployed to Preview – docs October 19, 2023 19:59 View deployment

vercel bot deployed to Preview – flagsmith-frontend-preview October 19, 2023 20:01 View deployment

vercel bot deployed to Preview – flagsmith-frontend-staging October 19, 2023 20:03 View deployment

Solve content types id

2b0b9d5

vercel bot deployed to Preview – flagsmith-frontend-preview October 19, 2023 20:29 View deployment

vercel bot deployed to Preview – docs October 19, 2023 20:30 View deployment

vercel bot deployed to Preview – flagsmith-frontend-staging October 19, 2023 20:32 View deployment

wrap the code with the enable_metadata flag

2293935

vercel bot deployed to Preview – flagsmith-frontend-preview October 19, 2023 20:52 View deployment

vercel bot deployed to Preview – docs October 19, 2023 20:52 View deployment

vercel bot deployed to Preview – flagsmith-frontend-staging October 19, 2023 20:54 View deployment

novakzaballa linked an issue Oct 19, 2023 that may be closed by this pull request

Add meta data fields to core entities #1610

Closed

Close MetadataSelect component

830a82a

vercel bot deployed to Preview – flagsmith-frontend-preview October 19, 2023 21:24 View deployment

vercel bot deployed to Preview – docs October 19, 2023 21:24 View deployment

vercel bot deployed to Preview – flagsmith-frontend-staging October 19, 2023 21:26 View deployment

novakzaballa requested review from a team and matthewelwell October 20, 2023 13:06

novakzaballa marked this pull request as ready for review October 20, 2023 13:21

Merge branch 'main' into feat/add-metadata-fields-to-core-entities

c1a0a7a

vercel bot deployed to Preview – flagsmith-frontend-preview December 15, 2023 18:38 View deployment

vercel bot had a problem deploying to Preview – docs December 15, 2023 18:39 Failure

vercel bot deployed to Preview – flagsmith-frontend-staging December 15, 2023 18:41 View deployment

Add metadata docs

dc60ee4

vercel bot deployed to Preview – docs December 15, 2023 18:47 View deployment

vercel bot deployed to Preview – flagsmith-frontend-preview December 15, 2023 18:49 View deployment

vercel bot deployed to Preview – flagsmith-frontend-staging December 15, 2023 18:51 View deployment

novakzaballa requested a review from kyle-ssg December 18, 2023 13:44

kyle-ssg reviewed Dec 18, 2023

View reviewed changes

frontend/web/components/pages/ProjectSettingsPage.js

}}

>

{metadata.content_type_fields.find(

(m) =>

Copy link

Member

kyle-ssg Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here

novakzaballa added 2 commits December 19, 2023 11:50

Adjust styles

28a5617

update test to support metadata query

0dc05e9

vercel bot deployed to Preview – flagsmith-frontend-preview December 21, 2023 13:32 View deployment

vercel bot deployed to Preview – docs December 21, 2023 13:34 View deployment

vercel bot deployed to Preview – flagsmith-frontend-staging December 21, 2023 13:36 View deployment

Merge branch 'main' into feat/add-metadata-fields-to-core-entities

1ec1125

vercel bot deployed to Preview – flagsmith-frontend-staging December 21, 2023 18:02 View deployment

vercel bot deployed to Preview – flagsmith-frontend-preview December 21, 2023 18:04 View deployment

vercel bot deployed to Preview – docs December 21, 2023 18:05 View deployment

novakzaballa closed this Dec 21, 2023

novakzaballa mentioned this pull request Dec 21, 2023

feat: Add metadata fields to core entities (FE) #3212

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add metadata fields to core entities #2861

feat: Add metadata fields to core entities #2861

novakzaballa commented Oct 18, 2023 •

edited

Loading

vercel bot commented Oct 18, 2023 •

edited

Loading

novakzaballa commented Dec 18, 2023

kyle-ssg Dec 18, 2023

novakzaballa Dec 22, 2023

kyle-ssg Dec 18, 2023

novakzaballa Dec 22, 2023

kyle-ssg Dec 18, 2023 •

edited

Loading

novakzaballa Dec 22, 2023

kyle-ssg Dec 18, 2023

kyle-ssg Dec 18, 2023

kyle-ssg Dec 18, 2023

novakzaballa Dec 22, 2023

kyle-ssg Dec 18, 2023

novakzaballa Dec 22, 2023

kyle-ssg Dec 18, 2023

kyle-ssg Dec 18, 2023

kyle-ssg Dec 18, 2023

		@@ -0,0 +1,37 @@
		import { FC, useEffect, useState } from 'react'

feat: Add metadata fields to core entities #2861

feat: Add metadata fields to core entities #2861

Conversation

novakzaballa commented Oct 18, 2023 • edited Loading

Changes

How did you test this code?

vercel bot commented Oct 18, 2023 • edited Loading

novakzaballa commented Dec 18, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kyle-ssg Dec 18, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

novakzaballa commented Oct 18, 2023 •

edited

Loading

vercel bot commented Oct 18, 2023 •

edited

Loading

kyle-ssg Dec 18, 2023 •

edited

Loading