Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable audit for import events #2849

Merged
merged 1 commit into from
Oct 17, 2023
Merged

fix: enable audit for import events #2849

merged 1 commit into from
Oct 17, 2023

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Oct 16, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This PR fixes import requests not emitting audit logs.

How did you test this code?

  1. Used the API endpoint to create an import request.
  2. Made sure the relevant audit logs have been created.

@khvn26 khvn26 requested review from a team and gagantrivedi October 16, 2023 10:26
@vercel
Copy link

vercel bot commented Oct 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Oct 16, 2023 10:26am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview Oct 16, 2023 10:26am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview Oct 16, 2023 10:26am

@github-actions github-actions bot added the api Issue related to the REST API label Oct 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023 •
edited
Loading

Uffizzi Preview deployment-38544 was deleted.

@matthewelwell matthewelwell merged commit 7964e49 into main Oct 17, 2023
@matthewelwell matthewelwell deleted the fix/import-audit branch October 17, 2023 09:35
@dabeeeenster dabeeeenster mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

@gagantrivedi gagantrivedi Awaiting requested review from gagantrivedi gagantrivedi was automatically assigned from Flagsmith/flagsmith

Assignees
No one assigned
Labels
api Issue related to the REST API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khvn26 @matthewelwell