feat: LaunchDarkly importer UI #2837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
front-end
|
Uffizzi Preview |
Closed
dabeeeenster
changed the title
Closed
kyle-ssg
reviewed
Oct 10, 2023
frontend/common/data/base/_data.js
Outdated
| @@ -19,7 +19,7 @@ module.exports = { | |||
| if (method !== 'get') | |||
| options.headers['Content-Type'] = 'application/json; charset=utf-8' | |||
|
|
|||
| if (this.token) { | |||
| if (this.token && !isExternal) { | |||
There was a problem hiding this comment.
I think this is part of a different PR
There was a problem hiding this comment.
Yes, it was a common solution for this #2842 too, which was just merged into main
khvn26
reviewed
Oct 16, 2023
khvn26
approved these changes
Oct 16, 2023
kyle-ssg
reviewed
Oct 17, 2023
frontend/common/data/base/_data.js
Outdated
| @@ -74,8 +74,8 @@ module.exports = { | |||
| return this._request('delete', url, data, headers) | |||
| }, | |||
|
|
|||
| get(url, data, headers) { | |||
| return this._request('get', url, data || null, headers) | |||
| get(url, data, headers, isExternal = false) { | |||
There was a problem hiding this comment.
I think I mentioned this in another PR, but we can just base this on if the url is Project.api in _request
khvn26
reviewed
Oct 17, 2023
Co-authored-by: Kim Gustyr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingChanges
How did you test this code?