Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: trial management in sales dashboard #2805

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

dabeeeenster
Copy link
Contributor

@dabeeeenster dabeeeenster commented Sep 25, 2023

This is so the sales team can manage folk going into and coming out of trials.

We need to clear up how we manage this data as we currently have two areas of the database that store this data, and we need to figure out which to honour based on the subscription state.

@vercel
Copy link

vercel bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 0:36am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 0:36am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 0:36am

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023

Uffizzi Preview deployment-36789 was deleted.

Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (e62be85) 95.53% compared to head (eceaa5f) 95.49%.
Report is 95 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2805      +/-   ##
==========================================
- Coverage   95.53%   95.49%   -0.04%     
==========================================
  Files         994     1013      +19     
  Lines       28072    29287    +1215     
==========================================
+ Hits        26818    27969    +1151     
- Misses       1254     1318      +64     
Files Coverage Δ
api/sales_dashboard/urls.py 100.00% <ø> (ø)
api/organisations/models.py 93.93% <66.66%> (+0.30%) ⬆️
api/sales_dashboard/views.py 57.97% <33.33%> (-3.32%) ⬇️
api/sales_dashboard/forms.py 50.98% <29.62%> (-25.02%) ⬇️

... and 64 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Nov 13, 2023
Merged via the queue into main with commit a056713 Nov 13, 2023
@matthewelwell matthewelwell deleted the feat/trial-management-in-sales-dashboard branch November 13, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants