Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix segments display crashing (#2770) #2789

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix: fix segments display crashing (#2770) #2789

merged 1 commit into from
Sep 19, 2023

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Sep 19, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This fixes issues with segments retrieval crashing when a trait value type unsupported by a segment operator is stored.
The new Flagsmith engine version performs necessary runtime checks to avoid this.

How did you test this code?

Relevant test cases have been added to Flagsmith engine's test suite.

@khvn26 khvn26 requested a review from gagantrivedi September 19, 2023 09:37
@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Sep 19, 2023 9:37am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview Sep 19, 2023 9:37am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview Sep 19, 2023 9:37am

@github-actions github-actions bot added the api Issue related to the REST API label Sep 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2023

Uffizzi Preview deployment-36287 was deleted.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (fce2e3a) 95.53% compared to head (cabec54) 95.53%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2789   +/-   ##
=======================================
  Coverage   95.53%   95.53%           
=======================================
  Files         994      994           
  Lines       28072    28072           
=======================================
  Hits        26818    26818           
  Misses       1254     1254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khvn26 khvn26 merged commit bb080d2 into main Sep 19, 2023
@khvn26 khvn26 deleted the fix/segments-crash branch September 19, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants