fix: Feature id in mv-option request is undefined

api/features/multivariate/views.py

@@ -1,5 +1,5 @@
 from drf_yasg.utils import swagger_auto_schema
-from rest_framework import viewsets
+from rest_framework import status, viewsets
 from rest_framework.decorators import api_view
 from rest_framework.generics import get_object_or_404
 from rest_framework.response import Response
@@ -33,6 +33,21 @@ def get_permissions(self):
             )
         ]
 
+    def create(self, request, *args, **kwargs):
+        feature_pk = self.kwargs.get("feature_pk")
+
+        if feature_pk == "undefined":
+            return Response(
+                status=status.HTTP_400_BAD_REQUEST,
+                data={"detail": "Feature Id cannot be 'undefined'."},
+            )
+
+        serializer = self.get_serializer(data=request.data)
+        if serializer.is_valid():
+            serializer.save()
+            return Response(serializer.data, status=status.HTTP_201_CREATED)
+        return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)
+
     def get_queryset(self):
         if getattr(self, "swagger_fake_view", False):
             return MultivariateFeatureOption.objects.none()

api/tests/integration/features/multivariate/test_integration_multivariate.py

@@ -34,6 +34,33 @@ def test_can_create_mv_option(client, project, mv_option_50_percent, feature):
     assert set(data.items()).issubset(set(response.json().items()))
 
 
+@pytest.mark.parametrize(
+    "client",
+    [lazy_fixture("admin_client")],
+)
+def test_cannot_create_mv_option_when_feature_id_is_undefined(client, project, feature):
+    # Given
+    url = reverse(
+        "api-v1:projects:feature-mv-options-list",
+        args=[project, "undefined"],
+    )
+
+    data = {
+        "type": "unicode",
+        "feature": feature,
+        "string_value": "bigger",
+        "default_percentage_allocation": 50,
+    }
+    # When
+    response = client.post(
+        url,
+        data=json.dumps(data),
+        content_type="application/json",
+    )
+    # Then
+    assert response.status_code == status.HTTP_400_BAD_REQUEST
+
+
 @pytest.mark.parametrize(
     "client",
     [lazy_fixture("admin_master_api_key_client"), lazy_fixture("admin_client")],

frontend/common/stores/feature-list-store.js

@@ -66,7 +66,7 @@ const controller = {
           (flag.multivariate_options || []).map((v) =>
             data
               .post(
-                `${Project.api}projects/${projectId}/features/${flag.id}/mv-options/`,
+                `${Project.api}projects/${projectId}/features/${res.id}/mv-options/`,
                 {
                   ...v,
                   feature: res.id,