fix: make OrganisationSubscriptionInformationCache.allowed_projects nullable
#2716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2716 +/- ##
==========================================
- Coverage 95.47% 95.47% -0.01%
==========================================
Files 986 987 +1
Lines 27729 27755 +26
==========================================
+ Hits 26474 26498 +24
- Misses 1255 1257 +2
☔ View full report in Codecov by Sentry. |
matthewelwell
commented
Aug 31, 2023
| @@ -582,6 +583,45 @@ def setUp(self) -> None: | |||
| ) | |||
| self.subscription = Subscription.objects.get(organisation=self.organisation) | |||
|
|
|||
| @mock.patch("organisations.views.extract_subscription_metadata") | |||
There was a problem hiding this comment.
I'm not happy about having to continue to use these class based tests but ripping these up into functional pytest tests would be a fairly large effort that I don't think this PR warrants right now.
matthewelwell
force-pushed
the
fix/chargebee-webhook-allowed_projects-integrity-error
branch
from
d6a9d07 to
cedad39
Compare
matthewelwell
deleted the
fix/chargebee-webhook-allowed_projects-integrity-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #2715
Note that null is assumed to mean no project limit (which should be the default for paid SaaS subscriptions).
How did you test this code?
Added unit test