Prevent invalid deletion of change requests and cascade delete feature states #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Uffizzi Preview |
gagantrivedi
approved these changes
Mar 13, 2023
matthewelwell
deleted the
1988-scheduled-change-requests-deletion-issues
branch
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1988 by ensuring that feature states are deleted when associated change requests are deleted. As part of this, it also prevents change requests from being deleted if the feature state is already live.
How did you test this code?
Added unit test. Note that there is a related change in the flagsmith/flagsmith-workflows repository as well.