fix: Adds permission groups to invite #5173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
github-actions
bot
added
front-end
Docker builds report
|
|
Uffizzi Preview |
tiagoapolo
force-pushed
the
fix/4002-permission-groups-invite
branch
from
4e6e4c8 to
2ea813c
Compare
There was a problem hiding this comment.
PR Overview
This PR adds a new feature to include permission groups when inviting users, while also converting the InviteUsers component to TypeScript and updating related modules. Key changes include:
- Converting the InviteUsers component from JavaScript to TypeScript with added support for permission groups.
- Updating the organisation store to include the permission_groups property in the invite payload.
- Modifying the GroupSelect component’s onAdd callback to incorporate an additional parameter (group name).
Reviewed Changes
| File | Description |
|---|---|
| frontend/web/components/modals/InviteUsers.tsx | New TypeScript invite component with permission groups functionality and click outside hook usage. |
| frontend/common/stores/organisation-store.js | Adds permission_groups to the invite payload. |
| frontend/web/components/GroupSelect.tsx | Updates onAdd callback signature to pass the group name. |
| frontend/web/components/modals/InviteUsers.js | Removal of legacy JavaScript invite component. |
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
frontend/web/components/modals/InviteUsers.tsx:107
- The function closeModal is referenced but not defined or imported in the component; please ensure it is declared or imported to avoid runtime errors.
closeModal()
kyle-ssg
reviewed
Mar 5, 2025
kyle-ssg
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Task: #4002
Changes
react-datepickerfrom version6.2.0to^8.1.0DateSelectcomponent by converting it from JavaScript to TypeScriptpermission_groupsto the invite object inorganisation-store.js.How did you test this code?