Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Segment override permissions #5134

Merged
merged 1 commit into from
Feb 19, 2025
Merged

fix: Segment override permissions #5134

merged 1 commit into from
Feb 19, 2025

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Removing segment overrides was based on the MANAGE_SEGMENTS permission rather than segment override permissions.

How did you test this code?

Viewed and modified segment overrides as a user with appropriate permissions.

@kyle-ssg kyle-ssg requested a review from a team as a code owner February 19, 2025 14:15
@kyle-ssg kyle-ssg requested review from tiagoapolo and removed request for a team February 19, 2025 14:15
@vercel Vercel
Copy link

vercel bot commented Feb 19, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 2:16pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 2:16pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Feb 19, 2025 2:16pm

@kyle-ssg kyle-ssg requested a review from rolodato February 19, 2025 14:15
@kyle-ssg kyle-ssg linked an issue Feb 19, 2025 that may be closed by this pull request
Deleting segment overrides is enforced by "Manage segments" permission in the frontend #5131
Closed
4 tasks
@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Feb 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 19, 2025 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5134 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5134 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5134 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-5134 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5134 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-5134 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 19, 2025 •
edited
Loading

Uffizzi Preview deployment-61097 was deleted.

@kyle-ssg kyle-ssg merged commit 66629e4 into main Feb 19, 2025
33 checks passed
@kyle-ssg kyle-ssg deleted the fix/segment-override-permissions branch February 19, 2025 14:50
@flagsmithdev flagsmithdev mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagoapolo tiagoapolo tiagoapolo approved these changes

@rolodato rolodato Awaiting requested review from rolodato

Assignees
No one assigned
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deleting segment overrides is enforced by "Manage segments" permission in the frontend
2 participants
@kyle-ssg @tiagoapolo